Skip to content

Comments

Add Sql StoredProcedures, UDFs and Triggers for CosmosDB resources#7201

Merged
erich-wang merged 14 commits intoAzure:masterfrom
MehaKaushik:master
Sep 25, 2019
Merged

Add Sql StoredProcedures, UDFs and Triggers for CosmosDB resources#7201
erich-wang merged 14 commits intoAzure:masterfrom
MehaKaushik:master

Conversation

@MehaKaushik
Copy link
Contributor

@MehaKaushik MehaKaushik commented Sep 12, 2019

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

  • I have reviewed the documentation for the workflow.
  • Validation tools were run on swagger spec(s) and have all been fixed in this PR.
  • The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

  • Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
  • adding/removing APIs.
  • adding/removing properties.
  • adding/removing API-version.
  • adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

  • If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
    Please follow the link to find more details on API review process.

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Sep 12, 2019 •
edited
Loading

In Testing, Please Ignore

[Logs] (Generated from c4257da, Iteration 15)

Failed Python: test-repo-billy/azure-sdk-for-python [Logs]
  • No packages generated.
Failed Java: test-repo-billy/azure-sdk-for-java [Logs] [Diff]
Succeeded Go: test-repo-billy/azure-sdk-for-go [Logs] [Diff]
Failed JavaScript: test-repo-billy/azure-sdk-for-js [Logs]
  • No packages generated.

@AutorestCI AutorestCI mentioned this pull request Sep 12, 2019
Closed
@AutorestCI
Copy link

AutorestCI commented Sep 12, 2019 •
edited
Loading

Automation for azure-sdk-for-python

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-python#7433

@AutorestCI
Copy link

AutorestCI commented Sep 12, 2019 •
edited
Loading

Automation for azure-sdk-for-go

Nothing to generate for azure-sdk-for-go

@openapi-sdkautomation openapi-sdkautomation bot mentioned this pull request Sep 12, 2019
Closed
@azuresdkci
Copy link
Contributor

azuresdkci commented Sep 12, 2019

Can one of the admins verify this patch?

@MehaKaushik MehaKaushik changed the title Adding Sql StoredProcedures for CosmosDB resources Adding Sql StoredProcedures, UDFs and Triggers for CosmosDB resources Sep 12, 2019
@erich-wang erich-wang added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Sep 16, 2019
@MehaKaushik MehaKaushik changed the title Adding Sql StoredProcedures, UDFs and Triggers for CosmosDB resources Add Sql StoredProcedures, UDFs and Triggers for CosmosDB resources Sep 17, 2019
ryansbenson
ryansbenson reviewed Sep 18, 2019
View reviewed changes
majastrz
majastrz requested changes Sep 18, 2019
View reviewed changes
Copy link
Member

@majastrz majastrz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added some comments. Please take a look.

@AutorestCI AutorestCI mentioned this pull request Sep 19, 2019
Merged
majastrz
majastrz approved these changes Sep 19, 2019
View reviewed changes
Copy link
Member

@majastrz majastrz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm fine approving from my side. There is still an unresolved comment from @ryansbenson. I'm leaving the final approval to him since he's still requesting changes on this PR.

@ryansbenson ryansbenson added ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review and removed ARMChangesRequested WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Sep 23, 2019
@MehaKaushik
Copy link
Contributor Author

MehaKaushik commented Sep 23, 2019

@erich-wang Please approve this.

@erich-wang erich-wang merged commit afc04c8 into Azure:master Sep 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ryansbenson ryansbenson ryansbenson left review comments

@majastrz majastrz majastrz approved these changes

@erich-wang erich-wang Awaiting requested review from erich-wang

Assignees

@erich-wang erich-wang

Labels

ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@MehaKaushik @AutorestCI @azuresdkci @majastrz @ryansbenson @erich-wang